Ethernet - Arduino Ethernet API compatibility layer #9522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Hello JAndrassy, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
JAndrassy
force-pushed
the
ethernet_compat_layer
branch
2 times, most recently
from
11cccb6 to
aae0d5b
Compare
JAndrassy
force-pushed
the
ethernet_compat_layer
branch
from
aae0d5b to
8698fef
Compare
|
Hi @JAndrassy We can accept your changes to ETH.h and ETH.cpp, but we think that the extra compatibility layer deserves it's own external library. Please remove the compatibility layer, so that we can merge your changes |
|
@me-no-dev, what is an "external library"? |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
External Library means that is hosted somewhere else. Usually github and is registered with Arduino libraries, so people can find it. |
|
the changes in ETH.h start with |
|
You can keep all changes in ETH, including that. |
|
new PR #9539 |
1 task
|
@me-no-dev I published the 'external library'. It uses IDF directly to add support for enc28j60. Implementation diffrences:
|
|
@JAndrassy periman is a good thing to have :) maybe add the library to the list of tested external libs here? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds legacy Arduino Ethernet API as a wrapper class for ETH object.
The filename EthernetCompat.h is the same as in the esp8266 Arduino.
In legacy Arduino Ethernet API static IP parameters are parameters of
begin. To set pins Arduino uses optionalinitmethod.Default setting in the wrapper is W5500 on default SPI pins with SS as CS. Default IRQ pin is 4 as in ETH (conflicting with SCK for C2 and C3).
Instance named
Ethernetis created. It wraps the ETH instance. It is possible to create additional instances.EthernetClient, EthernetServer and EthernetUdp are preprocessor macros (same way as their WiFi counterparts).
The example is taken from the Arduino Ethernet library. Only the comment about
initis modified.Tested with 'classic' ESP32 with W5500 on SPI with default pins and alternative pins and with spi_host2 on default and alternative pins. I will try to test with LAN8720 and maybe with a C3 with W5500.
Test sketch was LegacyEthernetTest from my NetAPIHelpers library and the new example.